1.x: Switch to vscode fork of sqlite3 #2170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmehren
added
the
type: maintenance
DerMolly
approved these changes
Mar 6, 2022
Microsoft maintains a fork of the sqlite3 package at https://github.com/microsoft/vscode-node-sqlite3 Switching to that allows us to drop various very old dependencies, removing 5 high security alerts in the process. References: TryGhost/node-sqlite3#1493 (comment) Signed-off-by: David Mehren <git@herrmehren.de>
All our dependencies already use recent-enough versions of these dependencies, so we don't need to override them anymore. Signed-off-by: David Mehren <git@herrmehren.de>
davidmehren
force-pushed
the
maint/master-dep-cleanup
branch
from
befabeb
to
62764f3
Compare
ErikMichelson
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component/Part
dependencies
Description
Microsoft maintains a fork of the sqlite3 package at
https://github.com/microsoft/vscode-node-sqlite3
Switching to that allows us to drop various very old dependencies,
removing 5 high security alerts in the process.
References:
TryGhost/node-sqlite3#1493 (comment)
Steps
made sure that:
masterfor 1.x & docs,developfor 2.xRelated Issue(s)