Add night mode detection #339
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firefox and Safari power a new CSS media query which allows to detect user's dark mode. This patch adds a JS implementation that toggles the our night mode automatically when a user's theme requests a dark mode. Resources: https://hacks.mozilla.org/2019/05/firefox-67-dark-mode-css-webrender/ https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>
|
@DerMolly Might want to look into this for the new frontend. Don't think it makes lots of sense to provide any new frontend code for 2.0 into this repository. |
|
Please create an issue in the react client repo |
|
I think we can close this here, as there is already a corresponding issue for the new frontend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox and Safari power a new CSS media query which allows to detect
user's dark mode. This patch adds a JS implementation that toggles the
our night mode automatically when a user's theme requests a dark mode.
Resources:
https://hacks.mozilla.org/2019/05/firefox-67-dark-mode-css-webrender/
https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme