Deprecate gen functions #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added this to the 
ghost
merged commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the
GenAPI more clear, I've decided to deprecate theGen.intandGen.floatfunctions.Gen.intI've added a new function calledGen.int32, so the naming is consistent across integer types.Gen.float, I don't see any reason for it since we already haveGen.double.Instead of outright removing these functions, I've marked them with
Obsoleteattributes, to make the upgrade path a little friendlier. The plan is to remove them completely following the0.11.0release.I'm still undecided on
Gen.byteandGen.sbyte.