Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applicative CE #400

Merged
merged 5 commits into from Jan 1, 2022
Merged

Applicative CE #400

merged 5 commits into from Jan 1, 2022

Conversation

TysonMN
Copy link
Member

@TysonMN TysonMN commented Dec 29, 2021

Resolves #268

...at least that is the plan. Currently this is a draft PR. I don't yet know how to add support for and! to the property CE.

This PR is stacked on top of PR #401, which is stacked on top of #399, which is stacked on top of #401. Those PRs should be completed first.

@TysonMN
Copy link
Member Author

TysonMN commented Dec 29, 2021

I don't yet know how to add support for and! to the property CE.

Figured it out. Now I just need to write a test and push the code.

@TysonMN TysonMN marked this pull request as ready for review December 30, 2021 16:00
@TysonMN
Copy link
Member Author

TysonMN commented Dec 30, 2021

Finished the work in this branch.

@TysonMN TysonMN force-pushed the applicative_CE branch 3 times, most recently from d852244 to b46ce29 Compare December 30, 2021 20:41
Copy link
Member

@dharmaturtle dharmaturtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only very, very minor thoughts. Otherwise LGTM! 🥳

src/Hedgehog/Property.fs Show resolved Hide resolved
tests/Hedgehog.Tests/GenTests.fs Outdated Show resolved Hide resolved
@TysonMN TysonMN merged commit 242bc4f into hedgehogqa:master Jan 1, 2022
@TysonMN TysonMN deleted the applicative_CE branch January 1, 2022 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

F# 5 applicative computation expression
2 participants