Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xml comments to Linq methods #430

Closed
wants to merge 3 commits into from
Closed

Conversation

JohnEffo
Copy link
Contributor

@JohnEffo JohnEffo commented Jul 3, 2023

What is this

Add XML documentation to Hedgehog.Linq so that C# consumers have a better experience.

@dharmaturtle dharmaturtle mentioned this pull request Jul 12, 2023
@JohnEffo
Copy link
Contributor Author

JohnEffo commented Aug 4, 2023

This nearly got added to #434 but did not make the cut, is there anything outstanding?

@TysonMN
Copy link
Member

TysonMN commented Aug 4, 2023

We haven't made that release yet.

@dharmaturtle reviewed this PR and gave feedback in a nonstandard way, namely by creating PR JohnEffo#1 that targets your otherr branch. We were waiting for you to review that PR. We should have pointed this out. Sorry for the confusion.

A minor issue I see is that this PR references your master branch while the PR by @dharmaturtle targets a different branch. Not a big deal, but might be confusing if you don't notice that.

@dharmaturtle
Copy link
Member

Ah whoops yeah I should've said something bout that PR here.

@JohnEffo
Copy link
Contributor Author

Closing this PR as it is looking at my master branch, created #447 which supersedes this request

@JohnEffo JohnEffo closed this Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants