Add first cut of style guide #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moodmosaic
reviewed
Apr 17, 2019
moodmosaic
reviewed
Apr 17, 2019
jacobstanley
requested changes
Apr 18, 2019
|
Perhaps we should add some |
|
I'm back from holidays so I'll be able to get back on this. :) |
jacobstanley
reviewed
May 4, 2019
| Foo xs -> | ||
| unlines xs | ||
| Bar xs -> | ||
| unlines xs |
There was a problem hiding this comment.
LambdaCase has to be one of my favorite extensions, so much less noise here.
jacobstanley
approved these changes
May 5, 2019
jacobstanley
requested changes
May 5, 2019
jacobstanley
approved these changes
May 21, 2019
…erything that isn't the top level to be a second level heading.
* Added note about line length * Added section on module imports/declarations * Updated section regarding use of typeclass constraints * Added note about use of LambdaCase extension * Added section about requiring documentation for all public facing functions.
jacobstanley
force-pushed
the
add-style-guide
branch
from
64114fe
to
a475c98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mined a recent PR for most of these so fair to say there is plenty of adjustment required.
But it is easier to have this discussion here.