Add histograms to labels / coverage #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moodmosaic
reviewed
Aug 8, 2022
| in | ||
| bar ('█', ['·', '▏', '▎', '▍', '▌', '▋', '▊', '▉']) | ||
|
|
||
| -- FIXME Maybe this should be configurable? |
There was a problem hiding this comment.
Indeed, it might be a good idea to have this configurable, @jacobstanley.
I've noticed that on (older) Windows machines without WSL/WSL2 and/or earlier versions of Windows 10 2004 (build 19041) the current bars won't render correctly (the last one, basically, '▉').
OTOH, this renders just fine:
--bar ('⣿', ['·', '⡀', '⡄', '⡆', '⡇', '⣇', '⣧', '⣷'])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unicode histograms / percentage bars to the new labelling / coverage system. Not sure if I have quite the right balance yet, but time will tell.
For labels with coverage requirements, the minimum required coverage is shown on the right hand side of the histogram, along with a tick or a cross indicating whether we met the requirement. We also highlight visually (with red dots) the additional coverage required to make it to the requirement, not sure if I like this yet but we'll give it go.
Shame 🇦🇺 🇬🇷 haven't won any world cups 😢