Include location of failed assertion in report #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes hedgehogqa#306. Adds the location of the failed assertion (taken from the Span value of the failure report). Example output: ``` ✗ <interactive> failed at test/Test/Hedgehog/Applicative.hs:91:11 after 1 test. ┏━━ test/Test/Hedgehog/Applicative.hs ━━━ 69 ┃ ... ``` This enables editors to easily parse the location of failed test assertions and provide links/jump functionality.
|
Looking great! 🎉 I'm surprised this prints like this (extra space shown as The code looks like that shouldn't be the case, just copy/paste error? |
|
Hmm, that is strange. I know the |
|
@jacobstanley OK the indent thing was likely a copy-paste error. Confirmed it's correctly indented in GHCi and in regular test runs through |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #306.
Adds the location of the failed assertion (taken from the
Spanvalue of the failure report). Example output:This enables editors to more easily parse the location of failed test assertions, and provide links/jump functionality. This has been tested with Emacs.