Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace HTraversable with TraversableB (from barbies) #412

Merged
merged 5 commits into from
May 8, 2021

Conversation

ocharles
Copy link
Contributor

Fixes #403

@ocharles
Copy link
Contributor Author

Open questions:

  • Should we reexport FunctorB and TraversableB?

@jacobstanley
Copy link
Member

  • Should we reexport FunctorB and TraversableB?

I'm thinking yes, mostly because HTraversable is currently exposed.

@@ -53,6 +53,7 @@ library
hedgehog
, hedgehog-quickcheck
, base >= 3 && < 5
, barbies
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
, barbies
, barbies >= 2.0 && < 2.1

(or whatever lower bound works)

@mitchellwrosen
Copy link

An update - I believe 2.0 is more or less the correct barbies lower bound (as Data.Functor.Barbie did not exist prior), but (I think?) it would require dropping support for GHC 8.0 and 8.2 due to this:

src/Data/Generics/GenericN.hs:40:1: error:
    • Kind signature on data type declaration has non-* return kind k
    • In the data family declaration for ‘Param’
   |
40 | data family Param (n :: Nat) (a :: k) :: k
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

@mitchellwrosen
Copy link

Ping!

@jacobstanley
Copy link
Member

it would require dropping support for GHC 8.0 and 8.2 due to this

That's a shame but I think it's probably ok.

@jacobstanley
Copy link
Member

jacobstanley commented May 8, 2021

I found that the required classes used to be in Data.Barbie and were moved to Data.Functor.Barbie in barbie-2.0.0.0

I've put in a module Hedgehog.Internal.Barbie which hides the required CPP.

@jacobstanley jacobstanley merged commit 37f56cb into hedgehogqa:master May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace HTraversable with Data.Functor.Barbie.TraversableB
3 participants