Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export shrinkPathCompress and shrinkPathDecompress #462

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

mbg
Copy link
Contributor

@mbg mbg commented Aug 24, 2022

In tasty-hedgehog, we run hedgehog properties one-at-a-time rather than in (Hedgehog) groups. This means that the TestCount component of the new Skip type is fairly useless to us. See my discussion in qfpl/tasty-hedgehog#61 (comment). However, the ShrinkPath component is useful. It would therefore be nice to have access to the shrinkPathCompress and shrinkPathDecompress functions, but they are not currently exported by the Hedgehog.Internal.Property. This PR changes this so that they are exported and also adds some documentation for them.

Copy link
Member

@moodmosaic moodmosaic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@moodmosaic
Copy link
Member

Thank you, @mbg. I went through qfpl/tasty-hedgehog#61 (comment) and hoping this would help you move forward with the update.

A new release of hedgehog will be up during the next days.

@moodmosaic moodmosaic merged commit 13581a6 into hedgehogqa:master Aug 24, 2022
@moodmosaic
Copy link
Member

Available in hedgehog 1.2.

@mbg mbg deleted the export-shrink-path-internals branch August 30, 2022 08:56
@mbg
Copy link
Contributor Author

mbg commented Aug 30, 2022

Awesome, thank you for reviewing and merging this so quickly last week, and thank you for releasing it pretty quickly as well!

@moodmosaic
Copy link
Member

No problem 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants