Replace exceptions dependency with safe-exceptions
#466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocharles
force-pushed
the
safe-exceptions
branch
from
d9da764
to
0bb5ef4
Compare
moodmosaic
reviewed
Sep 14, 2022
moodmosaic
reviewed
Sep 14, 2022
There was a problem hiding this comment.
Thank you @ocharles 👍
This PR looks reasonable, given the nature of async exceptions (coming outside of the current execution) which is something we never want to recover. Good to know that this helps tasty.
I just left a comment in the PR.
|
Great! I'll get these CI problem fixed up and then I'll squash it down to one commit. |
ocharles
force-pushed
the
safe-exceptions
branch
from
3158692
to
4b5460d
Compare
|
@moodmosaic Ok, all done! I think this is ready to go now. |
|
Thank you, @ocharles 👍 |
|
YW! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using
safe-exceptionswe avoid catching asynchronous exceptions, which aren't of any interest to Hedgehog. The current usage ofexceptionsis problematic, becausecheckReportcallscatchAny, which means it catches asynchronous exceptions. This is a problem fortasty-hedgehog, because it means that Tasty's timeout mechanism can't be used to timeout Hedgehog tests (qfpl/tasty-hedgehog#64, UnkindPartition/tasty#349)