Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GHC-9.6 #481

Merged
merged 1 commit into from Mar 27, 2023
Merged

Support GHC-9.6 #481

merged 1 commit into from Mar 27, 2023

Conversation

ysangkok
Copy link
Contributor

Fixes #480

@moodmosaic
Copy link
Member

Thank you! 🎯👍

@ysangkok
Copy link
Contributor Author

@moodmosaic Should I make a PR to remove the 8.0 and 8.2 builds, or should they get fixed?

@moodmosaic
Copy link
Member

I lean towards removing them. What do you think? /cc @ocharles @jacobstanley

@ysangkok
Copy link
Contributor Author

ysangkok commented Mar 25, 2023

@moodmosaic I found out why the build was failing! The reason is that newer versions of text and vector don't work with the Haddock documentation generation shipped with older versions of GHC. So we don't need to remove these GHC versions entirely, we just need to disable Haddocks for them. I reported submitted #482 which fixes the CI by doing that. That PR also links to the upstream bug report that I submitted. They are unwilling to work around this issue upstream, so we have to do it here.

@moodmosaic
Copy link
Member

Awesome, @ysangkok. That seems to be the best option, after all:

we don't need to remove these GHC versions entirely, we just need to disable Haddocks for them

Thank you 👍

@moodmosaic moodmosaic merged commit a4ceeea into hedgehogqa:master Mar 27, 2023
20 of 22 checks passed
@ysangkok ysangkok deleted the janus/th-2.20 branch March 27, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support GHC-9.6 (template-haskell-2.20)
2 participants