-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to disable the recheckAt
-message
#519
Conversation
@moodmosaic can you hold off with a new release for just a little bit longer? I may have more changes coming. |
f6333b2
to
2bdf341
Compare
2bdf341
to
f51874d
Compare
@sol, sure 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps a user would want to re-run the test this time using vanilla hedgehog? What happens then?
I don't need it myself, but if somebody requests it I'll add an option to Hspec that allows the user to explicitly request it (say Note that all Hspec options can be set through environment variable and config files (https://hspec.github.io/options.html#specifying-options-in-config-files), so it is easy for a user to specify what they want globally / per project. |
This is great, then. 👍 |
recheckAt
-messagerecheckAt
-message
Thanks @moodmosaic 🙏 |
Note that the shrink path ("11:b" in your screenshot) is still useful, but admittedly only if you know how to use it. If you're running with hspec (which I do) you need to do something like
Combining part of hedgehog's So I'd be sad about losing this, but as long as I can get it back with an environment variable I'm happy. I think the ideal would be that hspec gets a
but I don't know how likely that is. We'd need hspec to recognize a new command-line option; my memory from last I checked is that there's no way for downstream projects to add support for options that hspec itself doesn't explicitly recognize. And we'd need it to allow hedgehog to change the "to rerun" line, which I don't remember checking if that's currently possible but my guess is not. There's probably less ideal things that would still be an improvement on status quo for hspec users. To check, do I understand right that this would need a PR to hspec-hedgehog to take effect for hspec users? |
@ChickenProp can we move this discussion to #522? |
This is not useful in the context of
hspec-hedgehog
. Hspec uses its global seed when running hedgehog properties and it already prints instruction on how to re-run with the same seed when a test fails.