FIxes for upcoming ghc version #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hedgehog/src/Hedgehog/Internal/TH.hs
Outdated
| @@ -13,6 +14,9 @@ import Hedgehog.Internal.Discovery | |||
| import Hedgehog.Internal.Property | |||
|
|
|||
| import Language.Haskell.TH | |||
| #if MIN_VERSION_template_haskell(2, 12, 0) | |||
| hiding (TExpQ) | |||
| #endif | |||
| import Language.Haskell.TH.Syntax | |||
There was a problem hiding this comment.
This was lazy on my part, they should have been explicit imports from the beginning (then CPP wouldn't be required here.)
There was a problem hiding this comment.
I can make all the imports qualified or explicit, either just for this file or for all files. Your choice.
hedgehog/src/Hedgehog/Internal/TH.hs
Outdated
| import Language.Haskell.TH | ||
| import Language.Haskell.TH.Syntax | ||
| import Language.Haskell.TH (Exp (..), Q, TExp, location, runIO) | ||
| import Language.Haskell.TH.Syntax (Loc (..), mkName, unTypeQ, unsafeTExpCoerce) |
There was a problem hiding this comment.
Just a minor nit, can you remove the space between Exp and (..) to match the style of the rest of the project (same for Loc)
|
👍 after nitpick |
|
Fixed nitpicks, but I can't merge this. |
jacobstanley
added a commit
that referenced
this pull request
May 16, 2017
|
Rebased and merged 🌵 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.