Distributive class for pulling a transformer out to the top level #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobstanley
commented
Jun 10, 2017
| -- | ||
| withExceptT :: (Monad m, Show x, HasCallStack) => Test (ExceptT x m) a -> Test m a | ||
| withExceptT m = | ||
| withFrozenCallStack liftEither =<< runExceptT (distribute m) |
There was a problem hiding this comment.
I'm aware that this clashes with Control.Monad.Trans.Except.withExceptT but I'm not sure what else to call it. Whatever it's called it should be the same prefix as withResourceT I think.
There was a problem hiding this comment.
I'm going to go with this for now, if we decide to pick a different name it will be a breaking change anyway because of withResourceT so I don't see a reason to hold this up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perhaps adding a type class here is overkill, but I think we need the type family instances to make it manageable to use, so 🤷♂️
I think I'm going to go for it and see what happens.