Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add roundtrip test from Tim's blog post #85

Merged
merged 1 commit into from
Jun 11, 2017
Merged

Conversation

jacobstanley
Copy link
Member

I hope @thumphries doesn't mind, I turned his blog post in to an example.

While I was doing so I noticed that the tripping function could be improved a bit, I added an output with the intermediate value:
screen shot 2017-06-11 at 11 37 54 am

I understand that the intermediate value may not always be something supporting Show and could potentially be large, but I think this behaviour is a nice default. I think longer term we should have a trippingWith function which is a bit more configurable, but this is ok for now.

@jacobstanley jacobstanley merged commit a8572a4 into master Jun 11, 2017
@jacobstanley jacobstanley deleted the topic/roundtrip branch June 11, 2017 01:49
@thumphries
Copy link
Member

👍 glad to share it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants