MonadGen class to make working with transformers easier #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobstanley
commented
Jul 16, 2017
|
|
||
| genWellTypedExpr' :: Type -> Gen (Reader (Map Type [Expr])) Expr | ||
| genWellTypedExpr' :: Type -> ReaderT (Map Type [Expr]) Gen Expr |
jacobstanley
commented
Jul 16, 2017
| hoist (generalize . flip runReaderT mempty) (genWellTypedExpr' want) | ||
| genWellTypedExpr :: Type -> Gen Expr | ||
| genWellTypedExpr = | ||
| flip runReaderT mempty . genWellTypedExpr' |
This was referenced Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames
GentoGenTand introduces theMonadGenclass.The
MonadGenclass has instances for a number of transformers, includingReaderTandStateT. This means that it's now possible to use these transformers on the outside of aGen, as such I think it will be much more common to have a pureGen, so I've renamed the transformer variant toGenTand changedforAllto expect a pureGen. Folks can useforAllTif they need effects in their generators.I'm super happy with how this worked out, I think writing generators will be a lot cleaner now.