Enable customizations of the editor #25
Conversation
We provide a settings page, that enables the user to change all of Monaco's options except those that are irrelevant here
There was a problem hiding this comment.
Thank you very much for your contribution!
The PR looks good on the first glimpse! I will have a more detailed look (hopefully) in the next couple of days.
These two things trouble me:
- There are a lot of settings with this PR. I guess 80% of them are never changed by any user. This amount of settings makes refactoring the settings UI a lot more work. I think only the requested and the most important settings should be implemented.
- These settings are passed directly to monaco without validating them. Does JavaScript Prototype Poising apply? What are the risks that the settings go corrupt and monaco receives garbish, making the text editor unusable?
I yet have to build/try out your PR.
options.html
Outdated
| <p><label><input type="checkbox" id="scrollBeyondLastLine" data-setting="true"> Scroll beyond last line</label></p> | ||
| <p> | ||
| <label>Word wrap <select id="wordWrap" data-setting="true"> | ||
| <option value="off">Off</option> | ||
| <option value="on">On</option> | ||
| <option value="wordWrapColumn">Word wrap column</option> | ||
| <option value="bounded">Bounded</option> | ||
| </select></label> | ||
| </p> | ||
| <p> |
There was a problem hiding this comment.
These are a lot of settings. I think it might make sense to only add requested settings to keep the UI lean, what do you think?
There was a problem hiding this comment.
I assumed that if Microsoft put effort into implementing these settings, there are people that want them.
There was a problem hiding this comment.
I doubt vscode exposes all the those settings. Imo these settings are for programmers to customize Monaco to fit into the product, not necessarily for end users.
I'd love to hear more opinions on that.
My philosophy is usually "less is more", especially if I have to maintain it!
Maybe you can, alternatively, somehow reduce the redundancy in options.html? Ideally each setting should only correspond to a single line of code.
There was a problem hiding this comment.
I doubt vscode exposes all the those settings. Imo these settings are for programmers to customize Monaco to fit into the product, not necessarily for end users.
Not for all settings, but when I was in doubt, I checked if VSCode provides the setting. So you're both right and wrong at the same time 😄.
Maybe you can, alternatively, somehow reduce the redundancy in options.html? Ideally each setting should only correspond to a single line of code.
I had to type all of this stuff, so be sure I've thought about that 😆. I came up with the conclusion that there is nothing I can do to really reduce the number of HTML code here. By data-setting=true and automatically applying the setting based on the element ID, most of the work is done. I can reduce some of the code by custom elements, but I don't think this is worth (The most of the code is from the dropdowns, where I have to specify the options either way).
Edit: I'll try and write the conclusions here.
There was a problem hiding this comment.
Experience was good and it reduced the number of lines. Pushed.
I've thought about security, but considering that the settings object is both produced and consumed on the client side, I see no problem. The only way to exploit this messaging is by injecting a malware script into the page, and the only bad thing that can happen is corrupted editor, so that's not a problem. And BTW, if you can inject a script to the page there are worse thing you can do. |
|
@ChayimFriedman2 seems reasonable. |
|
Thank you! |
|
Btw. I think it would be a nice feature to highlight changed settings in bold. |
|
OK. I'm pretty busy this week, but maybe I'll find time to push this. |
|
Published with v0.5.0! |
|
Thanks for this @ChayimFriedman2! |
|
Oops, installation count dropped from 530 to 450 after requesting the "storage" permission! |
We provide a settings page, that enables the user to change all of Monaco's options except those that are irrelevant here.
There are two settings that I did not found a good way to express in the settings UI:
fontLigaturescan be a string or a boolean (currently only a checkbox for boolean), andrulersis an array.I'm not good with UX and the UI is minimal. If someone more knowledgeable than me would like to style it, I welcome suggestions.
Accessibility isn't good either, and again, if you know better than me what to do, please share it!
This fixes bunch of issues. Here's what I've found: