Fix Java JSON Parsing issues #208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually it seems dianestephens' solution for Rust from issue #129 works here in Java as well. Their solution is probably better than mine; would it be possible to merge their solution? |
Yes, I like their solution more, as it feels less hacky. Can you create a PR for it? Thanks for looking into it! ❤️ |
|
okay, I'll create a new PR then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is what others had in mind to fix this issue but I just tried parsing the string returned with JSON and returning 0 as variablesReference if it's a valid JSON string as described in #142.
This should resolve #148, #144, and #142.