Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attributes to control header and external source inclusion #44

Merged

Commits on May 17, 2022

  1. Add attributes to control header and external source inclusion

    emit_headers - controls whether header files are included in the generated compile_commands.json
    emit_externals - same, but for external sources or headers - bazel external workspace sources, etc.
    
    Both default to True - the existing behaviour.
    
    Some tools like ccls don't work well with headers in the compile_commands.json, and some large
    projects can generate very large compile_commands.json databases when including all external files.
    dave-hagedorn committed May 17, 2022
    Configuration menu
    Copy the full SHA
    8731aac View commit details
    Browse the repository at this point in the history
  2. Review comments

    Rename attributes - start with exclude_
    Rework external exclusion algorithm - use action targets and look for  prefix
    Tweak how python script passes options around
    dave-hagedorn committed May 17, 2022
    Configuration menu
    Copy the full SHA
    5c0c594 View commit details
    Browse the repository at this point in the history
  3. More Cleanup

    Remove extra whitespace
    Tweak  macro - default args are set to None, rely on inner rule's attribute's default values
    dave-hagedorn committed May 17, 2022
    Configuration menu
    Copy the full SHA
    b73e878 View commit details
    Browse the repository at this point in the history
  4. New approach, review comments

    Changed attributes to exclude_external_sources and exclude_headers
    dave-hagedorn committed May 17, 2022
    Configuration menu
    Copy the full SHA
    5d15503 View commit details
    Browse the repository at this point in the history
  5. Fix bad rebase

    dave-hagedorn committed May 17, 2022
    Configuration menu
    Copy the full SHA
    5a768e1 View commit details
    Browse the repository at this point in the history
  6. Typo

    dave-hagedorn committed May 17, 2022
    Configuration menu
    Copy the full SHA
    9204662 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2022

  1. More review comments, clean up header generation

    Change exclude_headers options to just all and external
    Optimize some header eclusion cases (thanks @cpsauer)
    Update docs
    dave-hagedorn committed May 21, 2022
    Configuration menu
    Copy the full SHA
    be9cd4a View commit details
    Browse the repository at this point in the history

Commits on May 23, 2022

  1. Fix crash intro'd in refactor

    Moved missing file error check to _get_files, names changed
    dave-hagedorn committed May 23, 2022
    Configuration menu
    Copy the full SHA
    619e2f5 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2022

  1. Configuration menu
    Copy the full SHA
    3726125 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2022

  1. Configuration menu
    Copy the full SHA
    3731aa8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d6690bf View commit details
    Browse the repository at this point in the history
  3. Only run external tagging if the settings require

    Also improve assert messaging and remove dead assert.
    cpsauer committed May 26, 2022
    Configuration menu
    Copy the full SHA
    416acd5 View commit details
    Browse the repository at this point in the history
  4. Deduplicate passing of action and arguments list

    Plus, fix a misplaced comment and some typos, old and new
    cpsauer committed May 26, 2022
    Configuration menu
    Copy the full SHA
    012e942 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2022

  1. Handle external generated files

    And do a little associated cleanup
    cpsauer committed May 28, 2022
    Configuration menu
    Copy the full SHA
    b57d32a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    93feefb View commit details
    Browse the repository at this point in the history
  3. Slim README section on new interface down to a brief summary and poin…

    …ters
    
    Sad, but probably necessary to keep most folks moving forward
    cpsauer committed May 28, 2022
    Configuration menu
    Copy the full SHA
    3b940f0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5f9083c View commit details
    Browse the repository at this point in the history