Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding south-up functions #5

Open
HedvigS opened this issue Jan 4, 2024 · 6 comments
Open

adding south-up functions #5

HedvigS opened this issue Jan 4, 2024 · 6 comments

Comments

@HedvigS
Copy link
Owner

HedvigS commented Jan 4, 2024

I think we should find a way to workin the functions over at skalyan91/south-up here. That way they'd be in a package people can install and run. What do you think @skalyan91 ?

@skalyan91
Copy link
Collaborator

I guess it would work, as long as we distribute the .qs files along with the package, and omit the code for creating those files. It would be a mess if we had to rely on obsolete versions of dependencies (as we’re currently doing with our use of groundhog)—fortunately those are only needed for creating the .qs files.

But I like the idea of including the south-up functions in our package!

@HedvigS
Copy link
Owner Author

HedvigS commented Jan 5, 2024

Cool!

I'm thinking we need to scale back a bit, maybe there's a way of simplifying the qs file structure.. I have some ideas. If you work on #1 i'll make a branch for south-up and we can review each other in... I don't know. No hurry right? :D

@skalyan91
Copy link
Collaborator

A week, maybe?

@HedvigS
Copy link
Owner Author

HedvigS commented Jan 5, 2024

A week, maybe?

Oh wow, yeah maybe. I'm teaching in Uppsala next week so I'm prepping. But... I do enjoy this :)!. We'll see.

@skalyan91
Copy link
Collaborator

Like you said, no hurry :).

@HedvigS
Copy link
Owner Author

HedvigS commented Aug 6, 2024

@skalyan91 I've added a beta-version of a function that does a baseman with just EEZ, not the elevation information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants