Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/grid view #38

Merged
merged 6 commits into from
Jul 8, 2020
Merged

Feat/grid view #38

merged 6 commits into from
Jul 8, 2020

Conversation

swellander
Copy link
Contributor

@swellander swellander commented Jul 8, 2020

Description

Implements a grid layout option. Screenshot

Context

Resolves Issue #23

More details

  • Repo names for this view don't link to their repos.
  • I had some trouble rendering emojis with the colon syntax (:star:) but using the unicode character directly seemed to work ok.

@hedyhli
Copy link
Owner

hedyhli commented Jul 8, 2020

Thank you so much! I love the view seen in your screenshot, I will test it later, but the tests seems to be failing due to black formatting, don't worry about that at the moment, although if you have black installed you can run black . and push the changes. If you don't then don't worry about it 😀

starcli/layouts.py Outdated Show resolved Hide resolved
@hedyhli
Copy link
Owner

hedyhli commented Jul 8, 2020

Awesome! Looks gorgeous on my computer, thanks for your contribution ;)

@hedyhli hedyhli merged commit 366b943 into hedyhli:main Jul 8, 2020
@hedyhli
Copy link
Owner

hedyhli commented Jul 8, 2020

@all-contributors please add @swellander for code

@allcontributors
Copy link
Contributor

@hedythedev

I've put up a pull request to add @swellander! 🎉

@hedyhli
Copy link
Owner

hedyhli commented Jul 8, 2020

✨ released on version 2.9.0, added you to list of contributors :)

@willmcgugan
Copy link

Hey. The grid layout looks great!

There is a gotcha to be aware of, with regards to truncating the title text with ellipsis. Asian characters can take up 2 “cells” in the terminal. So a title in Chinese may have a length of 10, but will be as wide as 20 characters of a Western alphabet.

You might want to use this method to truncate the title, which is aware of Asian characters.

@hedyhli
Copy link
Owner

hedyhli commented Jul 8, 2020

Thanks for your suggestion, I will try it out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add grid view option to --layout, implement grid view output
3 participants