Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃捇 Super teacher can delete public tags #5617

Merged
merged 11 commits into from
Jun 19, 2024
Merged

馃捇 Super teacher can delete public tags #5617

merged 11 commits into from
Jun 19, 2024

Conversation

Annelein
Copy link
Collaborator

@Annelein Annelein commented Jun 17, 2024

  • teacher1 is now always a super teacher in the dev_database
  • when a tag was deleted from an adventure, the popularity wasn't decreased
  • when you would add a tag to an adventure without a name, it would throw a 500 because the adventure wouldn't exist without a name
  • some cleaning up

How to test
Add some tags in (public) adventures and delete them as a Super Teacher
Screenshot 2024-06-17 at 14 38 03

Copy link
Member

@jpelay jpelay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Copy link
Contributor

mergify bot commented Jun 17, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Jun 18, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Jun 19, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 06a369f into main Jun 19, 2024
12 checks passed
@mergify mergify bot deleted the delete-tags branch June 19, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants