Skip to content
This repository has been archived by the owner on Jul 23, 2022. It is now read-only.

Remove kotlin plugin from library #71

Closed
joielechong opened this issue Jun 11, 2019 · 3 comments
Closed

Remove kotlin plugin from library #71

joielechong opened this issue Jun 11, 2019 · 3 comments

Comments

@joielechong
Copy link
Contributor

For the library module, I think you can safely remove the apply plugin: 'kotlin-android' and implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version" from dependencies. I try running the sample app with the two above removed and the app is running smoothly.

I can send you a PR to let me remove them.

@hedzr
Copy link
Owner

hedzr commented Jun 11, 2019

You're right, @joielechong , that's my bad.
Waiting for the PR on master, we would release it with our works.

@joielechong
Copy link
Contributor Author

@hedzr: I have create a PR.. please take a look. ;)

@joielechong
Copy link
Contributor Author

Thanks for the merge!

Guiorgy added a commit that referenced this issue Jun 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants