Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows Terminal #55

Open
essenciary opened this issue Jun 14, 2021 · 2 comments
Open

Add Windows Terminal #55

essenciary opened this issue Jun 14, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@essenciary
Copy link

This is awesome:
https://github.com/microsoft/terminal

@heetbeet
Copy link
Owner

What do you think would be the best approach to add Windows Terminal:

  • Bundle it with Juliawin (✗ extra 30mb, ✗ not integrated with host's wt.exe, ✓ will always work)
  • Try looking for it on the host computer (✓ integrated with host, ✗ not necessarily available)
  • A bit of both (give option to include during installation, but still try to see if host has Windows Terminal otherwise)

And how would you like it integrated into Juliawin:

  • Add new launcher julia-terminal.exe that will open a julia instance in windows terminal (and pass the command line arguments). Outside of Windows Terminal, like cmd, this will require a new window to pop-up.
  • Change juliawin-prompt.exe to launch through Windows Terminal
  • Try some clever magic to integrate this in julia.exe, e.g. do some introspection to see if Julia is launched from a non-terminal-like place (like from windows explorer) and then give it a default terminal of Windows Terminal in stead of cmd. If it is launched from a terminal, ignore Windows Terminal and just open it in the current terminal. This might require some extreme tricks to get just right.

@heetbeet heetbeet added the enhancement New feature or request label Jun 16, 2021
@RoyiAvital
Copy link

I'd go with the first option as the main feature of JuliaWin is portability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants