Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backend/env: treat empty environment variables as not found #78

Merged
merged 1 commit into from Nov 20, 2019
Merged

backend/env: treat empty environment variables as not found #78

merged 1 commit into from Nov 20, 2019

Commits on Nov 19, 2019

  1. backend/env: treat empty environment variables as not found 

    It's very unusual to distinguish between an environment variable
that's unset and one that's empty. When a value is required, looking
for a non-empty environment variable feels more correct.

As a recent example, the kafka-go config contained a "required" entry
for `KAFKA_ADDRS` which was satisfied by an empty environment
variable.
    @rogpeppe
    rogpeppe committed Nov 19, 2019
    Copy the full SHA
    e08055b View commit details
    Browse the repository at this point in the history