Abort save when unable to finish

In these two cases, the project's file will not contain the latest changes, so returning as if the save is complete is incorrect and can lead to data loss (such as on app quit).
heewa · May 13, 2021 · ccacf33 · ccacf33
1 parent 91b0409
commit ccacf33
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/src/App/Document.cpp b/src/App/Document.cpp
@@ -2398,8 +2398,8 @@ class BackupPolicy {
 
         Base::FileInfo tmp(sourcename);
         if (tmp.renameFile(targetname.c_str()) == false) {
-            Base::Console().Warning("Cannot rename file from '%s' to '%s'\n",
-                                    sourcename.c_str(), targetname.c_str());
+            throw Base::FileException(
+                "Cannot rename tmp save file to project file", targetname);
         }
     }
     void applyTimeStamp(const std::string& sourcename, const std::string& targetname) {
@@ -2531,9 +2531,8 @@ class BackupPolicy {
 
         Base::FileInfo tmp(sourcename);
         if (tmp.renameFile(targetname.c_str()) == false) {
-            Base::Console().Error("Save interrupted: Cannot rename file from '%s' to '%s'\n",
-                                  sourcename.c_str(), targetname.c_str());
-            //throw Base::FileException("Save interrupted: Cannot rename temporary file to project file", tmp);
+            throw Base::FileException(
+                "Save interrupted: Cannot rename temporary file to project file", tmp);
         }
 
         if (numberOfFiles <= 0) {