Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin only shows some of my folders #4

Closed
brokencode64 opened this issue Jan 12, 2024 · 5 comments · Fixed by #5
Closed

Plugin only shows some of my folders #4

brokencode64 opened this issue Jan 12, 2024 · 5 comments · Fixed by #5
Assignees
Labels
bug Something isn't working

Comments

@brokencode64
Copy link

Describe the bug
I have some hundreds of folders and subfolders, it seems that the plugin only shows about 100 of them? I cannot choose the folder that I would prefer to sync to under options or when trying to create a new sync note.

To Reproduce
Steps to reproduce the behavior:

  1. Go to options
  2. Click on RemoteMarkdownSync
  3. Click on the field called select default notebook

Expected behavior
It should be possible to see all folders or search for folders

Version(please complete the following information):

  • OS: Arch Linux 6.6.10
  • Joplin Version: 2.13.13
  • Plugin Version: 1.1.3
@brokencode64 brokencode64 added the bug Something isn't working label Jan 12, 2024
Copy link

Hi, thank for reporting an issue, we will check it out very soon

@hegerdes
Copy link
Owner

Hi, thanks for raising this. I will look into it.

Since I don't have that many notebooks can you please add an screenshot? Does this only happen in the settings for the default notebook or also when creating a new sync note (when you have the notebook drop-down)? Exactly 100?

It might be likely that the joplin internal api has a limit of returned notebooks at one request and currently there is no pagination for implemented in the client.

@brokencode64
Copy link
Author

I suspect your a right that it is something internal to joplin. I tried counting, and it does seem to be exactly 100.

As to exactly which notebooks are shown up, it seems to be somewhat random, but perhaps it has to do with how joplin internally organizing notebooks? It is always the same notebook even if I create new ones. I can scroll for quite a bit, but it only shows a small number of the notes I have.

It happens both in setting and when trying to create a new sync note.

From "settings" page:
Screenshot_20240112_202029

Creating a new sync note:
Screenshot_20240112_202546

Example of a few notebooks (with subnotebooks) that never show up:
Screenshot_20240112_202631

@hegerdes
Copy link
Owner

Added a PR that fixes it. But also found another small bug.

Will release new version on sundry or monday

hegerdes added a commit that referenced this issue Jan 13, 2024
fix: show all notebook in selector - closes #4
@hegerdes
Copy link
Owner

Is released - update should be picked up by Joplins store in a couple of hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants