Payments #59
Payments #59
Conversation
hei-ryan
force-pushed
the
payments
branch
5 times, most recently
from
c1bd68b
to
b8dc673
Compare
|
SonarCloud Quality Gate failed. |
| parameters: | ||
| - name: status | ||
| in: query | ||
| description: "Filter fees by status. Available status are PAID, UNPAID and LATE" |
There was a problem hiding this comment.
Do not enumerate statuses here as they may change. Just say: See the PaymentStatus object for its value.
| operationId: getFees | ||
| responses: | ||
| '200': | ||
| description: List of all student fees |
| /students/{student_id}/fees/{fee_id}/payments: | ||
| get: | ||
| tags: | ||
| - Paying | ||
| summary: Get all student payments | ||
| summary: Get all student payments for one specific fee ordered by creation datetime desc |
There was a problem hiding this comment.
of as specific fee. Resulting list is ordered by...
| in: query | ||
| schema: | ||
| $ref: '#/components/schemas/PageSize' | ||
| operationId: getStudentFeePayments |
| responses: | ||
| '200': | ||
| description: Created student payments | ||
| description: Created student payments, |
| insert into "payment" | ||
| (id, fee_id, type, comment,amount, creation_datetime) | ||
| values | ||
| ('payment1_id','fee1_id', 'CASH', 'Comment', 2000, '2022-11-08T08:25:24.00Z'), |
There was a problem hiding this comment.
Use a richer set of data. Use all types. And sometimes set comment to null.
Also, add the MOBILE_MONEY type, which requires comment to be set when used (check is done on the Java side, not Postgres).
FIX type also requires comment to be set (to be checkd on Java side)
| @@ -88,10 +105,48 @@ void student_pages_are_ordered_by_reference() throws ApiException { | |||
| assertTrue(isBefore(page2.get(0).getRef(), page2.get(2).getRef())); | |||
| } | |||
|
|
|||
| @Test | |||
| void fees_page_are_ordered_by_due_datetime_desc() throws ApiException { | |||
| } | ||
|
|
||
| @Test | ||
| void payments_page_are_ordered_by_due_datetime_desc() throws ApiException { |
| PayingApi api = new PayingApi(student1Client); | ||
| int pageSize = 2; | ||
|
|
||
| List<Fee> page1 = api.getStudentFees(STUDENT1_ID, 1, pageSize); |
There was a problem hiding this comment.
Can you check whether we put ordered indexes (of the approriate orderding) on fee.due_datetime (DESC) and payment.creation_datetime (DESC or ASC, I don't remember)? https://www.postgresql.org/docs/current/indexes-ordering.html
When we now that we will ALWAYS (or very often) return a list ordered by some attribute, we add such ordered indexes. Warning: if the index order is DIFFERENT from the request submitted, then we may have dramatic result!
There was a problem hiding this comment.
Actually, we didn't index yet the fee.due_datetime(DESC) and payment.creation_datetime(DESC). For our use case, the most recent (descending) order is the most efficient, and I don't think there is a case where we should change this order.
So I think we can put ordered (DESC) indexes for these fields.
| ApiClient manager1Client = anApiClient(MANAGER1_TOKEN); | ||
| PayingApi api = new PayingApi(manager1Client); | ||
| CreatePayment toCreate1 = creatablePayment1().amount(null); | ||
| CreatePayment toCreate2 = creatablePayment1().amount(-1); |
There was a problem hiding this comment.
Unless type is FIX! But just create a ticket for addressing FIX types for the moment
There was a problem hiding this comment.
My above comment is bad. Indeed, amount can NEVER be negative. The FIX type is used to cancel fees that we don't want pay (eg: fees that we created falsly).
There was a problem hiding this comment.
For sure, but this feature is not still implemented so I've created a ticket anyway : #60
hei-teacher
requested review from
hei-teacher
and removed request for
hei-teacher
No description provided.