Fix code style issues and add php7.2 support to travis.yml

heidelpay · Feb 21, 2017 · ed07f31 · ed07f31
1 parent aee0d18
commit ed07f31
Show file tree

Hide file tree

Showing 9 changed files with 29 additions and 15 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -18,6 +18,13 @@ matrix:
       env: deps=low
     - php: 7.1
       env: deps=high
+      php: 7.2
+      env: deps=no
+      php: 7.2
+      env: deps=low
+      php: 7.2
+      env: deps=high
+
 
 cache:
   directories:
@@ -34,7 +41,6 @@ before_script:
 
 script:
   - ./vendor/bin/phpunit --coverage-clover build/logs/clover.xml
-  - ./vendor/bin/phpunit
   - ./vendor/bin/php-cs-fixer fix --dry-run --diff --verbose
 
 after_success:

diff --git a/lib/ParameterGroups/AccountParameterGroup.php b/lib/ParameterGroups/AccountParameterGroup.php
@@ -190,7 +190,6 @@ public function getIban()
         return $this->iban;
     }
 
-
     /**
      * AccountIdentification getter
      *

diff --git a/lib/ParameterGroups/BasketParameterGroup.php b/lib/ParameterGroups/BasketParameterGroup.php
@@ -31,7 +31,6 @@ class BasketParameterGroup extends AbstractParameterGroup
      * @var string reference id of a transmitted basket (optional)
      */
     public $id = null;
-
 
     /**
      * BasketId getter

diff --git a/lib/PaymentMethodes/AbstractPaymentMethod.php b/lib/PaymentMethodes/AbstractPaymentMethod.php
@@ -17,8 +17,7 @@
  * @subpackage PhpApi
  * @category PhpApi
  */
-
-use \Heidelpay\PhpApi\Exceptions\UndefinedTransactionModeException;
+use Heidelpay\PhpApi\Exceptions\UndefinedTransactionModeException;
 
 abstract class AbstractPaymentMethod
 {

diff --git a/tests/Unit/ParameterGroups/AccountParameterGroupTest.php b/tests/Unit/ParameterGroups/AccountParameterGroupTest.php
@@ -21,6 +21,7 @@ class AccountParameterGroupTest extends TestCase
 {
     /**
      * Bank getter/setter test
+     *
      * @test
      */
     public function Bank()
@@ -35,9 +36,9 @@ public function Bank()
 
     /**
      * BankName getter/setter test
+     *
      * @test
      */
-
     public function BankName()
     {
         $Account = new Account();
@@ -63,6 +64,7 @@ public function testBrand()
 
     /**
      * Bic getter/setter test
+     *
      * @test
      */
     public function Bic()
@@ -75,9 +77,9 @@ public function Bic()
         $this->assertEquals($value, $Account->getBic());
     }
 
-
     /**
      * Country getter/setter test
+     *
      * @test
      */
     public function Country()
@@ -116,9 +118,9 @@ public function testIban()
         $this->assertEquals($value, $Account->getIban());
     }
 
-
     /**
      * Sepa Mandate Identification getter/setter test
+     *
      * @test
      */
     public function Identification()
@@ -172,6 +174,7 @@ public function testNumber()
 
     /**
      * Verification getter/setter test
+     *
      * @test
      */
     public function Verification()

diff --git a/tests/Unit/ParameterGroups/BasketParameterGroupTest.php b/tests/Unit/ParameterGroups/BasketParameterGroupTest.php
@@ -22,6 +22,7 @@ class BasketParameterGroupTest extends TestCase
 {
     /**
      * BasketId getter/setter test
+     *
      * @test
      */
     public function Id()
@@ -36,19 +37,20 @@ public function Id()
 
     /**
      * GetClassName test
+     *
      * @test
      */
-
     public function getClassName()
     {
         $Basket = new Basket();
 
         $value = "Heidelpay\PhpApi\ParameterGroups\BasketParameterGroup";
-        $this->assertEquals($value,$Basket->getClassName());
+        $this->assertEquals($value, $Basket->getClassName());
     }
 
     /**
      * Undefined property exception test
+     *
      * @test
      */
     public function undefinedPropertyExcetion()

diff --git a/tests/Unit/ParameterGroups/ContactParameterGroupTest.php b/tests/Unit/ParameterGroups/ContactParameterGroupTest.php
@@ -47,6 +47,7 @@ public function testIp()
 
     /**
      * Mobile setter/getter test
+     *
      * @test
      */
     public function Mobile()
@@ -61,6 +62,7 @@ public function Mobile()
 
     /**
      * Phone setter/getter test
+     *
      * @test
      */
     public function Phone()

diff --git a/tests/Unit/ParameterGroups/NameParameterGroupTest.php b/tests/Unit/ParameterGroups/NameParameterGroupTest.php
@@ -21,6 +21,7 @@ class NameParameterGroupTest extends TestCase
 {
     /**
      * Birthdate getter/setter test
+     *
      * @test
      */
     public function Birthdate()
@@ -74,6 +75,7 @@ public function testFamily()
 
     /**
      * Salutation getter/setter test
+     *
      * @test
      */
     public function Salutation()
@@ -85,8 +87,10 @@ public function Salutation()
 
         $this->assertEquals($value, $Name->getSalutation());
     }
+
     /**
      * Title getter/setter test
+     *
      * @test
      */
     public function Title()

diff --git a/tests/Unit/PaymentMethodes/AbstractPaymentMethodTest.php b/tests/Unit/PaymentMethodes/AbstractPaymentMethodTest.php
@@ -32,7 +32,6 @@ class AbstractPaymentMethodTest extends TestCase
      *
      * @var \Heidelpay\PhpApi\PaymentMethodes\SofortPaymentMethod
      */
-
     protected $paymentObject = null;
 
     /**
@@ -49,6 +48,7 @@ public function setUp()
 
     /**
      * Request setter/getter test
+     *
      * @test
      */
     public function Request()
@@ -61,6 +61,7 @@ public function Request()
 
     /**
      * Response setter/getter test
+     *
      * @test
      */
     public function Response()
@@ -70,6 +71,7 @@ public function Response()
 
     /**
      * Adaptere setter/getter test
+     *
      * @test
      */
     public function Adapter()
@@ -82,26 +84,24 @@ public function Adapter()
 
     /**
      * getPaymentUrl test
+     *
      * @test
      */
     public function getPaymentUrl()
     {
-
         $this->paymentObject->getRequest()->getTransaction()->set('mode', 'LIVE');
         $this->assertEquals('https://heidelpay.hpcgw.net/ngw/post', $this->paymentObject->getPaymentUrl());
     }
 
     /**
      * getPaymentUrl exception test
+     *
      * @test
      */
     public function getPaymentUrlException()
     {
         $this->paymentObject->getRequest()->getTransaction()->set('mode', null);
         $this->expectException(UndefinedTransactionModeException::class);
         $this->paymentObject->getPaymentUrl();
-
-
     }
-
 }