Fix a psalm issue with templates

ArrayObject needs a Template definition for static analysis
heiglandreas · Apr 26, 2022 · f0f2a99 · f0f2a99
1 parent 52c6751
commit f0f2a99
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/HolidayIterator.php b/src/HolidayIterator.php
@@ -34,8 +34,15 @@
 
 use ArrayObject;
 
+/**
+ * @template-extends ArrayObject<int, HolidayIteratorItemInterface>
+ */
 class HolidayIterator extends ArrayObject
 {
+    /**
+     * @param mixed $value
+     * @return void
+     */
     public function append($value)
     {
         if (! $value instanceof HolidayIteratorItemInterface) {

diff --git a/src/Holidaychecker.php b/src/Holidaychecker.php
@@ -45,7 +45,6 @@ public function __construct(HolidayIterator $iterator)
 
     public function check(DateTimeInterface $date): Holiday
     {
-        /** @var HolidayIteratorItemInterface $entry */
         foreach ($this->iterator as $entry) {
             if ($entry->dateMatches($date)) {
                 return new Holiday($entry->isHoliday(), $entry->getName());