Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support React 15.2.0. Update Babel dependencies. #67

Closed
wants to merge 1 commit into from

Conversation

plemarquand
Copy link

Fixes #65
Fixes #66

@camsjams
Copy link

+1

@basilfx
Copy link

basilfx commented Jul 26, 2016

This version seems to work with react-bootstrap 0.30.0.

@camsjams
Copy link

camsjams commented Jul 26, 2016

@basilfx Agreed!

If you look at version 0.30.0 of React Bootstrap, there is no component named Input, but in React Bootstrap Validation v0.1.11 for the ValidatedInput component, there is a reference to the Input component, which leads to an error: super expression must be null or a function

@basilfx
Copy link

basilfx commented Jul 26, 2016

@camsjams But this PR doesn't use Input, but FormControl. Your link references to the source of this repository, not the source of this PR.

I found that it renders fine, but I have some other problems using value links right now.

@camsjams
Copy link

Ah sorry, misunderstood your original comment. We are in agreement 👍

@ghost
Copy link

ghost commented Jul 29, 2016

@plemarquand Wouldn't it make more sense if the ValidatedInput component was called ValidatedFormGroup (or similar) since it renders a FormGroup, not a FormControl?

@ir-fuel
Copy link

ir-fuel commented Aug 4, 2016

Can this be merged please? There is no way of using this lib with React 15 right now as I get the "Uncaught TypeError: Super expression must either be null or a function, not undefined" on usage of ValidatedInput in my project :(

@ir-fuel
Copy link

ir-fuel commented Aug 7, 2016

Upon taking a closer look, this isn't a plugin replacement for the old version. In the older versions of react-bootstrap the Input component both had a label and a text field. So did the ValidatedInput component. In this new version only the text field has been taken into account, not the previously supported label, so basically this breaks the old behaviour of the component.

@ghost
Copy link

ghost commented Aug 12, 2016

@ir-fuel For me it still works fine in React 15. If I understand correctly, this is meant to be used as a replacement to react-bootstrap's new FormControl. You would put your own FormGroup and ControlLabelaround it, which is why no label prop is needed.

@LoicUV
Copy link

LoicUV commented Aug 24, 2016

@gchameleon except if you need to specify the validationState on the FormGroup for styling purposes which is a react-bootstrap standard now, you can't. Or any other implementation that relied on using label now doesn't work as @ir-fuel stated.

@nguyenbathanh
Copy link

I couldn't make this work. The errors are not showing in form.

@plemarquand plemarquand closed this Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React 15.2.0 Warnings: Unknown props Input bootstrap element is deprecated
6 participants