-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support React 15.2.0. Update Babel dependencies. #67
Conversation
+1 |
This version seems to work with react-bootstrap 0.30.0. |
@basilfx Agreed! If you look at version 0.30.0 of React Bootstrap, there is no component named |
@camsjams But this PR doesn't use Input, but FormControl. Your link references to the source of this repository, not the source of this PR. I found that it renders fine, but I have some other problems using value links right now. |
Ah sorry, misunderstood your original comment. We are in agreement 👍 |
@plemarquand Wouldn't it make more sense if the |
Can this be merged please? There is no way of using this lib with React 15 right now as I get the "Uncaught TypeError: Super expression must either be null or a function, not undefined" on usage of ValidatedInput in my project :( |
Upon taking a closer look, this isn't a plugin replacement for the old version. In the older versions of |
@ir-fuel For me it still works fine in React 15. If I understand correctly, this is meant to be used as a replacement to |
@gchameleon except if you need to specify the validationState on the FormGroup for styling purposes which is a react-bootstrap standard now, you can't. Or any other implementation that relied on using label now doesn't work as @ir-fuel stated. |
I couldn't make this work. The errors are not showing in form. |
Fixes #65
Fixes #66