Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added async submit for textConcatType #8

Merged
merged 6 commits into from
Nov 5, 2020
Merged

added async submit for textConcatType #8

merged 6 commits into from
Nov 5, 2020

Conversation

maku05
Copy link
Contributor

@maku05 maku05 commented Oct 29, 2020

No description provided.

koertho
koertho requested changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@koertho koertho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Denke im großen und ganzen passt es, habe nur ein paar kleine Anmerkugnen und es fehlt noch der compilierte JavaScript.

CHANGELOG.md Show resolved Hide resolved
src/Resources/npm-package/js/contao-filter-bundle.js Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Oct 29, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 5.335% when pulling bf88d92 on autocomplete into fa6ee69 on master.

@maku05 maku05 requested a review from koertho October 30, 2020 10:54
@koertho
Copy link
Contributor

koertho commented Nov 4, 2020

@AlexejKossmann Kannst du bitte hier nochmal checken, gerade auch wegen meiner Anmerkung beim JS?

koertho
koertho approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@koertho koertho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passt von meiner Seite aus. Kannst gerne noch den Changelog raus löschen, bei Pull-Requests nehmen wir den Pull-Request-Titel und erstellen den Changelog hinterher

@maku05 maku05 merged commit 10b5f03 into master Nov 5, 2020
@maku05 maku05 deleted the autocomplete branch November 5, 2020 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koertho koertho koertho approved these changes

@AlexejKossmann AlexejKossmann AlexejKossmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maku05 @coveralls @koertho @AlexejKossmann