Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schreibfehler #1

Merged
merged 4 commits into from Dec 1, 2016
Merged

Schreibfehler #1

merged 4 commits into from Dec 1, 2016

Conversation

Floxn
Copy link
Contributor

@Floxn Floxn commented Nov 30, 2016

In Zeile 15 hat sich ein Schreibfehler eingeschlichen.
Es stand 'jquery-noconflict' => 'system/modules/hast_plus/assets/js/jquery-noconflict.min.js' statt 'jquery-noconflict' => 'system/modules/haste_plus/assets/js/jquery-noconflict.min.js'

In Zeile 15 hat sich ein Schreibfehler eingeschlichen.
Es stand 'jquery-noconflict' => 'system/modules/hast_plus/assets/js/jquery-noconflict.min.js' statt 'jquery-noconflict' => 'system/modules/haste_plus/assets/js/jquery-noconflict.min.js'
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add the last line break back.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How i can save it without the line break?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I mean you should save it with the line break ;). Or maybe I interpreted the PR wrong?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fritzmg There was no trailing new line but now there is. You can see this when you hover the icons at the end of line. Therefore, now it is correct, he removed the line without newline and added one with a newline.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, sorry, mixed that up.

@fatcrobat fatcrobat merged commit ff08086 into heimrichhannot:master Dec 1, 2016
@fatcrobat
Copy link
Contributor

Thanks, merged. Will add new tag shortly.

@fatcrobat fatcrobat added the bug label Dec 1, 2016
@fatcrobat fatcrobat added this to the 1.5.4 milestone Dec 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants