Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Configuration to skipp html tags #5

Merged
merged 5 commits into from
Apr 12, 2021

Conversation

AlexejKossmann
Copy link
Contributor

This PR allows to add html tags to configuration files, to be completly skipped from hyphernating.

Copy link
Contributor

@koertho koertho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me. I added just some little remarks. BUT 😨 there is a test for this class and such a functionality should really have tests. So I would prefer to update the tests (and please move them to github actions).

src/DependencyInjection/Configuration.php Outdated Show resolved Hide resolved
src/DependencyInjection/Configuration.php Show resolved Hide resolved
src/Hyphenator/FrontendHyphenator.php Show resolved Hide resolved
Copy link
Contributor

@koertho koertho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me!

@AlexejKossmann AlexejKossmann merged commit 737ec72 into master Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants