fix phpstan errors, add phpstan to ci pipeline

heimrichhannot · Feb 24, 2023 · 6163f15 · 6163f15
1 parent 8fc9bd6
commit 6163f15
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 1 deletion.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -63,3 +63,20 @@ jobs:
         run: |
           composer global require php-coveralls/php-coveralls
           php-coveralls --coverage_clover=build/logs/clover.xml -v
+
+  phpstan:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: 8.0
+
+      - name: Checkout
+        uses: actions/checkout@v2
+
+      - name: Install the dependencies
+        run: composer install --no-interaction
+
+      - name: PHPStan
+        run: vendor/bin/phpstan analyse -c phpstan.neon
diff --git a/src/Util/Request/UrlUtil.php b/src/Util/Request/UrlUtil.php
@@ -101,6 +101,7 @@ public function makeUrlRelative(string $url, array $options = []): string
             'removeLeadingSlash' => false,
         ], $options);
 
+        /** @var array|false $urlParts */
         $urlParts = parse_url($url);
 
         if (false === $urlParts) {

diff --git a/src/Util/Ui/AccordionUtil.php b/src/Util/Ui/AccordionUtil.php
@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright (c) 2022 Heimrich & Hannot GmbH
+ * Copyright (c) 2023 Heimrich & Hannot GmbH
  *
  * @license LGPL-3.0-or-later
  */
@@ -18,6 +18,12 @@ class AccordionUtil
      */
     private $contaoFramework;
 
+    /** @var array */
+    private $accordionStartStopCache = [];
+
+    /** @var array */
+    private $accordionSingleCache;
+
     public function __construct(ContaoFramework $contaoFramework)
     {
         $this->contaoFramework = $contaoFramework;