Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service integration email filters #31

Merged
merged 2 commits into from Oct 21, 2021
Merged

Conversation

tibibo
Copy link

@tibibo tibibo commented Oct 21, 2019

Required for adding support for email filters and parsers configuration for email service integrations
https://github.com/terraform-providers/terraform-provider-pagerduty/issues/88

@tibibo
Copy link
Author

tibibo commented Oct 28, 2019

@heimweh could you review, please?

Copy link

@SpamapS SpamapS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm nobody, but this seems correct to me, and would remove some clicking-hacks from our automation.

@stmcallister
Copy link
Collaborator

@tibibo thanks for submitting this! Unfortunately, this is an undocumented part of the PagerDuty API. I've been trying to hunt down the answer of whether there is a plan on documenting it. Once I have that I can make the decision of whether to merge this (and the subsequent feature in the Terraform provider) or not. I'll post back to this thread when I get an answer.

@JanMinervum
Copy link

I was looking into this as well, and stumbled upon this PR. Any updates on this? Or is there another way to set custom rules for e-mailmanagement through Terraform?

@tibibo
Copy link
Author

tibibo commented Apr 6, 2021

@stmcallister as I see missing part have added in documentation —  https://developer.pagerduty.com/api-reference/reference/REST/openapiv3.json/paths/~1services~1%7Bid%7D~1integrations/post (Check tab "Email Integration With Filters"). Could you review this PR, please.

@jregovic
Copy link

Can this get merged?

Copy link
Collaborator

@stmcallister stmcallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Sorry for the delay on reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants