doc-map: fix tile bitflag interpretation #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66-m
changed the title
66-m
changed the title
|
The problem is that it's not clear what a horizontal flip is. Does the x-axis remain in place or the y-axis? Both could reasonably be described as a horizontal flip. We need more precise language here. |
|
Relevant context: ddnet/ddnet#6132
The codebase had a different interpretation than the editor. I made the change to X/Y, which sadly didn't get any discussion, but should hopefully be more intuitive. This should ofc be updated in the map docs 👍 |
The interpretation for the horizontal and vertical flips from the bitflag is the other way around. The order of flips doesn't matter since it gives the same result, but to avoid confusion I swapped it too. Also clarified what the flip directions mean.
heinrich5991
force-pushed
the
doc-map-bitflag
branch
from
715e3bc
to
05fd5e4
Compare
|
Thanks for your pull request! I somehow forgot about it… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interpretation for the horizontal and vertical flips from the bitflag is the other way around.
The order of flips doesn't matter since it gives the same result, but to avoid confusion i swapped it too