Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Pip install huffman #99

Closed
wants to merge 1 commit into from

Conversation

ChillerDragon
Copy link
Contributor

No description provided.

@ChillerDragon
Copy link
Contributor Author

Should probably test installing it from the local source not from pypi. But I could not find the readme with the build instructions for the python package.

@ChillerDragon
Copy link
Contributor Author

This pipeline used to pass for me 3 months ago https://github.com/ChillerDragon/teeworlds-web-traffic-decoder/commits/master/

@heinrich5991
Copy link
Owner

Should probably test installing it from the local source not from pypi. But I could not find the readme with the build instructions for the python package.

Yes. I believe it was "do what you do to get any Python project built". I had to look it up again, found it at https://packaging.python.org/en/latest/tutorials/packaging-projects/: python -m build.

@ChillerDragon
Copy link
Contributor Author

I didn't even see the pyproject.toml because i was looking in the huffman directory not in uniffi.

@ChillerDragon
Copy link
Contributor Author

It is now building, installing and running the python package.

@heinrich5991 heinrich5991 force-pushed the master branch 2 times, most recently from 0928346 to b713968 Compare July 7, 2024 20:39
@heinrich5991
Copy link
Owner

I added it to the existing CI. Thanks for your PR which prompted me to do this. I wanted to improve upon this PR in two ways:

  1. It tested in three different Python versions which I didn't find necessary.
  2. The unit test was quite ad-hoc. I added structured Python unit tests instead.

Superseded by 83f22db.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants