Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression 1.5.8 - Recreate fragments when swiping is locked #125

Closed
kevinthecity opened this issue Sep 3, 2016 · 3 comments
Closed

Regression 1.5.8 - Recreate fragments when swiping is locked #125

kevinthecity opened this issue Sep 3, 2016 · 3 comments
Assignees
Labels
Milestone

Comments

@kevinthecity
Copy link

kevinthecity commented Sep 3, 2016

There seems to be a regression in 1.5.8 that prevents customs fragments from being interacted with if they have canGoForward set to false.

  1. I have a custom fragment that has canGoForward overwritten with a boolean to return false until a condition is met in the custom fragment.
  2. Tapping anywhere on the screen dismisses the keyboard and all touch events start getting eaten.

If you follow the code in the debugger, you'll eventually see that notifyDatasetChanged() is called as soon as you tap on the screen, leading me to believe that the following commit is the offending commit.

4d5af6d

My guess is the intercept touch code is not working as expected for custom fragments, or that the locking logic isn't quite right. If you have a hard time reproducing I can try and create a sample project.

Heres a gif of what it looks like in practice.

cantclickgif

@kevinthecity kevinthecity changed the title Regression 1.5.8 - Recreate fragments when swiping is lock Regression 1.5.8 - Recreate fragments when swiping is locked Sep 3, 2016
@Daerex
Copy link

Daerex commented Sep 6, 2016

Hi! Same problem here. While canGoForward return false the widgets are locked. Greetings!

PD: Thanks for your hard work :)

@daniel-stoneuk
Copy link
Collaborator

daniel-stoneuk commented Sep 6, 2016

Yeah, this is a pretty major bug. Same thing happening here. I am guessing that commit 4d5af6d was the culprit. This is way worse than the previous issue as it totally renders my login setup useless.

Here's a little video of more glitched behaviour. Working on a pull request now.
ezgif com-video-to-gif 1

Keep up the great work!

Edit: I see that kevinthecity has already noted that.

@daniel-stoneuk
Copy link
Collaborator

I have made a pull request with a fix. All working great now. 😄 #128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants