Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More slide types #2

Closed
heinrichreimer opened this issue Feb 21, 2016 · 7 comments
Closed

More slide types #2

heinrichreimer opened this issue Feb 21, 2016 · 7 comments
Assignees

Comments

@heinrichreimer
Copy link
Owner

This issue should track progress of more slide types.

Current slide types:

  • SimpleSlide: Standard slide featuring a title, short description and image like Google's intros.
  • FragmentSlide: Custom slide containing a Fragment or a layout resource.
  • Slide: Base slide. If you want to modify what's shown in your slide this is the way to go.

Ideas:

  • ParallaxSlide: Slide that has multiple layers and creates a nice parallax effect.
@kabouzeid
Copy link

Base Slide could include a public String[] getPermissions() and ask the user to grant them on Marshmallow.

My bad, should have checked out the sample app before posting here :D

@Maxr1998
Copy link
Contributor

I suggest adding a CustomView slide, which allows adding a View instead of the image.

@heinrichreimer
Copy link
Owner Author

@Maxr1998 I think this is already possible using FragmentSlide.
@kabouzeid SimpleSlide now supports permission validation.

@Maxr1998
Copy link
Contributor

Or a modified simple slide with custom layout. Forget about my suggestion :D

@heinrichreimer
Copy link
Owner Author

@Maxr1998 just call SimpleSlide.Builder.layout(R.layout.your_custom_layout) and you should be done.

@Maxr1998
Copy link
Contributor

That's what I did, and that's why I said forget about it :)

BTW @heinrichreimer did you see my PR?

@heinrichreimer
Copy link
Owner Author

@Maxr1998 Perfect!

Yes I've seen it, have to take a look at it when I'm home.

CMircea added a commit to TaxiBarby/material-intro that referenced this issue Oct 10, 2020
Handle NullPointerException with updateButtonNextDrawable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants