-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force close when not supplying all options to SimpleSlide.Builder #5
Comments
You must supply at least a background color, a title, a description and an image. |
Sure, but shouldn't there at least be some kind of check or default text, not just a plain crash? |
It throws an |
Hm, ok. In my opinion that's not ideal, but ok. I don't want to meddle in your work, especially as it's so wonderful :) |
What should be the desired behavior? |
Well, if the id is null, just supply no text. Should I create a PR? |
I would appreciate that |
@Maxr1998 Your pull request contains only one small error. Would you please fix that, so that I can merge it? |
Oops, I'm terribly sorry. Didn't see the notifications the last days. Did you fix the issue yourself? |
No, I can't edit your pill request... Would be happy if you edit it |
I fixed it in my code, but I guess I also need to send a new pull request.. |
Don't require setting all values, fix #5 (2)
Crashes in Fragment constructor when loading Resource ids from Fragment arguments, as some of them are 0x0.
The text was updated successfully, but these errors were encountered: