Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to configure the mail button? #58

Closed
sirtet opened this issue May 7, 2015 · 5 comments
Closed

How to configure the mail button? #58

sirtet opened this issue May 7, 2015 · 5 comments

Comments

@sirtet
Copy link

sirtet commented May 7, 2015

i got shariff and the backend working, but the mail button initially did just open the page in a new tab, with ?view=mail attached to the URL.
I expected it to work without config, as the other buttons.
I thought it would open a mail with a set subject, and the page URL in the body, like seen here:
http://granaton.com/shariff-social-sharing-wordpress/

With data-mail-url="mailto:foo@example.com" added to the div, the mail program opens with a recipient set, but no other content...

Do i need to configure something else?

EDIT:
I was wondering what the idea behind the default value ?view=mail for data-mail-url was.
Now i saw on heise online, that it's used there to bring up a webform to mail the article...
So, it DOES look like the mail button needs extra config.

@pmb0 pmb0 closed this as completed in fe6a6ae May 8, 2015
@pmb0
Copy link
Member

pmb0 commented May 8, 2015

Just released v1.12.0. Now you are able to use data-mail-subject and data-mail-body to customize the mail. Defaults are current page's title (subject) and current page's url (body).

@Williwurstig
Copy link

data-mail-subject doesn't seem to work. Module uses always data-title.

@richard67
Copy link
Contributor

@Williwurstig Note that according to the readme docs, data-mail-subject and data-mail-bodyare only used if the data-mail-url is a mailto: link, i.e. starts with mailto:. Is that the case in your situation?

@Williwurstig
Copy link

Yes, the mailto: is there, but empty:
<div class="myshariff" data-mail-body="Link: {url}" data-mail-subject="This is the subject" data-mail-url="mailto:">
output:
<a href="mailto:?subject=Pagetitle&amp;body=Link%3A%0Ahttp%3A%2F%2Ftestdomain.de" title="Per E-Mail versenden" role="button" aria-label="Per E-Mail versenden"><span class="fa fa-envelope"></span><span class="share_text">mail</span></a>

Can anybody confirm this?

@richard67
Copy link
Contributor

richard67 commented Feb 10, 2018

@Williwurstig I can confirm that.

I've tested and checked the source code, too. It seems that either the readme docs are not up to date, or the functionality is not implemented by mistake, because the option "data-mail-subject" is not used at all in the code.

Can you open a new issue for this here? I think developers don't get notified about comments on closed issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants