This repository has been archived by the owner on Jul 6, 2023. It is now read-only.
client: disable issued at time claim in jwt #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the server may need a corresponding change. (Some of) the tests are failing due to the iat claim being missing. Perhaps we should make this configurable for backwards compatibility reasons? |
From dgrijalva/jwt-go#139 it is understood that if the machine where jwt token is generated and/or the machine where jwt token is verified have any clock skew then there is a possibility of getting a "Token used before issued" error. Considering that we also check for expiration with delta of 5 minutes, disabling iat claim until the patch is merged in jwt. Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
raghavendra-talur
force-pushed
the
fix-jwt-issue
branch
from
151531b
to
9d3b86c
Compare
|
retest this please |
obnoxxx
approved these changes
Jul 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From dgrijalva/jwt-go#139 it is understood
that if the machine where jwt token is generated and/or the machine
where jwt token is verified have any clock skew then there is a
possibility of getting a "Token used before issued" error. Considering
that we also check for expiration with delta of 5 minutes, disabling
iat claim until the patch is merged in jwt.
Signed-off-by: Raghavendra Talur rtalur@redhat.com
What does this PR achieve? Why do we need it?
This PR disables the issued at time claim in jwt. Doing so will stop "token used before issued" errors.
Does this PR fix issues?
Fixes #646
Notes for the reviewer