Add block volume count to metrics

[Madhu-1]

Add block volume count to metrics

What does this PR achieve? Why do we need it?

This PR adds the block volume count to the metrics

Does this PR fix issues?

Fixes: rhbz#1589012

Signed-off-by: Madhu Rajanna mrajanna@redhat.com

logs:

#HELP heketi_block_volumes_count Number of block volumes on cluster
# TYPE heketi_block_volumes_count gauge
heketi_block_volumes_count{cluster="812506b5c3063c72b3cfc467951100c6"} 3
# HELP heketi_volumes_count Number of volumes on cluster
# TYPE heketi_volumes_count gauge
heketi_volumes_count{cluster="812506b5c3063c72b3cfc467951100c6"} 4

[Madhu-1]

@phlogistonjohn @obnoxxx @raghavendra-talur PTAL

[centos-ci]

Can one of the admins verify this patch?

[phlogistonjohn]

ok to test

[phlogistonjohn]

LGTM

[openshift-merge-robot]

/retest

[openshift-merge-robot]

/retest

[obnoxxx]

This looks good, as far as the server code changes go, but I request the tests to be expanded to cover the gluster-block bits: certainly apps/glusterfs/app_topology_test.go. It seems that pkg/metrics/metrics_test.go only covers clusters, nodes, devices, and bricks so far, so we may expand that in a later PR.

[Madhu-1]

@obnoxxx added test case of block volume PTAL

[openshift-ci-robot]

@Madhu-1: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/simple	9e8111f	link	/test simple

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[obnoxxx]

Thanks for adding the test, LGTM!