be consistent with how we format headers #301
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were close to a consensus on most of this, but now everything
follows the same format:
The only real changes / decisions:
#pragma once
instead of include guards. We were about 50/50.I think the pragma looks cleaner and is easier, so I went that way.
I think this is easier to parse as it groups the things this header
is defining together instead of putting this random build artifact
in the middle
think any files were #define only, but even if they were, I'd be
inclined to still include the guards to be consistent across all
headers and more importantly to reduce the chance that it's forgetten
if a method is added.