be consistent about our defintion of main
#341
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #338.
This mostly implements the discussion from the issue thread, it:
_start
in crt1 as weak_start
in tests where access memory regions is niceint main(void)
In the original issue thread, we'd suggested a prototype of
void main(void)
,as Tock currently ignores the return value of processes. Unfortuntely,
-Wall
turns on
-Wmain
by default, which results inwhile we could explicitly turn this off (
-Wno-main
), my current feeling isthat writing
int main
is pretty stock for C, and having a return value from aprocess may be useful someday (i.e. returning 0 means this process meant to
exit). Sure, most things probably won't ever return, but I don't think it hurts
to stick with C convention here and let things return a value.