Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tag_latest_prusaslicer.sh to pull the most-recent release, including preview builds #12

Closed
wants to merge 1 commit into from

Conversation

longman391
Copy link

Now pulls a pre-release version if it's the latest tagged build. This mirrors the behavior set within PrusaSliver itself, where it will alert the user if there is a new build available, not just anything tagged "latest."

Now pulls a pre-release version if it's the latest tagged build.
@longman391 longman391 mentioned this pull request Apr 24, 2023
@longman391
Copy link
Author

Different approach and more features, but note that this has just been incorporated into the upstream repo: dmagyar/prusaslicer-vnc-docker#1 (comment)

@helfrichmichael
Copy link
Owner

Hi @longman391 , sorry for the delay. I'm adjusting my notifications for GitHub to make sure I don't miss these.

Happy to do a pull, but I'm wondering if it's worth having 2 branches (stable/prerelease) for the prusaslicer-novnc docker container. Shouldn't be unreasonable.

Otherwise if there's strong confidence in the Prusa beta offerings, I'm happy to merge this PR.

@markrossington
Copy link

A prerelease branch (as long as you can grab it via :prerelease or whatever in Docker would be great.

@longman391
Copy link
Author

Hi @longman391 , sorry for the delay. I'm adjusting my notifications for GitHub to make sure I don't miss these.

Happy to do a pull, but I'm wondering if it's worth having 2 branches (stable/prerelease) for the prusaslicer-novnc docker container. Shouldn't be unreasonable.

Otherwise if there's strong confidence in the Prusa beta offerings, I'm happy to merge this PR.

It would be AWESOME to have another branch for prerelease, thanks! Oftentimes Prusa only has support for their newest printers on the prerelease branch, so for those of us with beta hardware and new hardware, there's no way to use this docker without prerelease support.

Thank you!

@helfrichmichael
Copy link
Owner

Sorry again for the delay here. I gave an update on #10 (comment). I think since latest is now the latest, we'll avoid merging this in, but ideally I'll keep the builds updating more frequently and include pre-releases.

@helfrichmichael helfrichmichael added the wontfix This will not be worked on label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants