Fix: Queue consumed whole memory on inverter timeout

When the poll interval was e.g. 1sec it was possible that the queue ran full and consumed the whole memory. Now new entries are only added to the queue automatically if the queue is empty. This issue also caused a lot of "DTU command failed" messages.
helgeerbe · Apr 25, 2023 · 0441bbb · 0441bbb
1 parent 5996fb0
commit 0441bbb
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/lib/Hoymiles/src/Hoymiles.cpp b/lib/Hoymiles/src/Hoymiles.cpp
@@ -54,7 +54,7 @@ void HoymilesClass::loop()
                 }
             }
 
-            if (iv != nullptr && iv->getRadio()->isInitialized() && iv->getRadio()->isIdle()) {
+            if (iv != nullptr && iv->getRadio()->isInitialized() && iv->getRadio()->isQueueEmpty()) {
                 _messageOutput->print("Fetch inverter: ");
                 _messageOutput->println(iv->serial(), HEX);
 

diff --git a/lib/Hoymiles/src/HoymilesRadio.cpp b/lib/Hoymiles/src/HoymilesRadio.cpp
@@ -69,4 +69,9 @@ bool HoymilesRadio::isInitialized()
 bool HoymilesRadio::isIdle()
 {
     return !_busyFlag;
-}
+}
+
+bool HoymilesRadio::isQueueEmpty()
+{
+    return _commandQueue.size() == 0;
+}
diff --git a/lib/Hoymiles/src/HoymilesRadio.h b/lib/Hoymiles/src/HoymilesRadio.h
@@ -12,6 +12,7 @@ class HoymilesRadio {
     virtual void setDtuSerial(uint64_t serial);
 
     bool isIdle();
+    bool isQueueEmpty();
     bool isInitialized();
 
     template <typename T>