Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap CAN bus library to better support newer ESPs #135

Merged

Conversation

MalteSchm
Copy link

Hi,

I tried to get my Pylontech Battery to speak to the ESP today but was not successful.
The can library (CAN.h) that is used for this link has a number of pending pull requests that seem to be related to newer ESPs. I tried to use the lib with a different device in the past and had similar issues.
I switched to twai.h which is more up to date. Also expressif claims that there are some HW related fixes implemented in this lib. I was able to read the Pylontech battery values with this change.

@berni2288 I understand that you have committed this feature originally. Can you check and comment?

Also I replaced the Messages printout.

Thanks,
Malte

@MalteSchm MalteSchm changed the title swap can library to better support newer ESPs swap CAN bus library to better support newer ESPs Mar 12, 2023
@berni2288
Copy link

Hi @MalteSchm,

thanks so much for your PR! 👍 This is a really great bugfix!
I also had problems with the CAN lib. At first it worked well for a couple of weeks, but then it suddenly stopped working for some of the CAN data values and it prooved to be not really relieable.
I just checked out our branch and all the values reported to MQTT look correct now.

💯 Kudos! I'll do a few more checks and then merge your PR.

@berni2288 berni2288 changed the base branch from master to development March 12, 2023 17:22
@berni2288 berni2288 merged commit c7f6aea into hoylabs:development Mar 12, 2023
@berni2288
Copy link

@helgeerbe I've merged this into development.

@MalteSchm MalteSchm deleted the pylontech_can_bus_lib_change branch March 12, 2023 19:17
Copy link

github-actions bot commented Apr 7, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants